Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Str 1099 update get checkpoint info rpc #687

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Str 1099 update get checkpoint info rpc #687

wants to merge 4 commits into from

Conversation

bewakes
Copy link
Contributor

@bewakes bewakes commented Feb 25, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 19.04762% with 68 lines in your changes missing coverage. Please review.

Project coverage is 54.52%. Comparing base (ff4da8d) to head (7d065c2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/consensus-logic/src/csm/worker.rs 0.00% 27 Missing ⚠️
...rates/consensus-logic/src/csm/client_transition.rs 31.03% 20 Missing ⚠️
crates/rpc/types/src/types.rs 0.00% 9 Missing ⚠️
bin/strata-client/src/rpc_server.rs 0.00% 4 Missing ⚠️
crates/state/src/client_state.rs 60.00% 4 Missing ⚠️
bin/prover-client/src/operators/checkpoint.rs 0.00% 2 Missing ⚠️
crates/db/src/types.rs 0.00% 2 Missing ⚠️ 
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
+ Coverage   54.47%   54.52%   +0.04%     
==========================================
  Files         320      320              
  Lines       34407    34360      -47     
==========================================
- Hits        18744    18735       -9     
+ Misses      15663    15625      -38
Files with missing lines Coverage Δ
crates/btcio/src/reader/handler.rs 0.00% <ø> (ø)
crates/btcio/src/reader/query.rs 56.11% <100.00%> (-0.09%) ⬇️
crates/sequencer/src/checkpoint/worker.rs 0.00% <ø> (ø)
crates/state/src/operation.rs 45.00% <ø> (ø)
bin/prover-client/src/operators/checkpoint.rs 0.00% <0.00%> (ø)
crates/db/src/types.rs 42.40% <0.00%> (ø)
bin/strata-client/src/rpc_server.rs 0.00% <0.00%> (ø)
crates/state/src/client_state.rs 59.49% <60.00%> (+4.25%) ⬆️
crates/rpc/types/src/types.rs 0.00% <0.00%> (ø)
...rates/consensus-logic/src/csm/client_transition.rs 72.80% <31.03%> (+2.03%) ⬆️
... and 1 more

... and 5 files with indirect coverage changes

@github-actions GitHub Actions
Copy link
Contributor

Commit: 5512b48

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,370,501 ✅
EL_BLOCK 97,878 ✅
CL_BLOCK 93,515 ✅
L1_BATCH 30,419,221 ✅
L2_BATCH 3,432 ✅
CHECKPOINT 25,769 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bewakes